[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues
From: |
Esteban Bosse |
Subject: |
Re: [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues |
Date: |
Tue, 22 Oct 2019 11:39:44 +0200 |
User-agent: |
Evolution 3.30.5-1.1 |
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió:
> We will move this code, fix its style first.
>
> Reviewed-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/pci-host/piix.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 95b04122fa..1544c4726b 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -133,9 +133,10 @@ static PCIINTxRoute
> piix3_route_intx_pin_to_irq(void *opaque, int pci_intx);
> static void piix3_write_config_xen(PCIDevice *dev,
> uint32_t address, uint32_t val, int
> len);
>
> -/* return the global irq number corresponding to a given device irq
> - pin. We could also use the bus number to have a more precise
> - mapping. */
> +/*
> + * Return the global irq number corresponding to a given device irq
> + * pin. We could also use the bus number to have a more precise
> mapping.
> + */
> static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx)
> {
> int slot_addend;
Reviewed-by: Esteban Bosse <address@hidden>
- Re: [PATCH v2 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically, (continued)
- [PATCH v2 10/20] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create(), Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 11/20] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 12/20] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create(), Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 14/20] hw/pci-host/piix: Move RCR_IOPORT register definition, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 15/20] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 16/20] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues, Philippe Mathieu-Daudé, 2019/10/18
- Re: [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues,
Esteban Bosse <=
- [PATCH v2 18/20] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c, Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 19/20] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx', Philippe Mathieu-Daudé, 2019/10/18
- [PATCH v2 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces, Philippe Mathieu-Daudé, 2019/10/18
- Re: [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge, no-reply, 2019/10/19
- Re: [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge, Aleksandar Markovic, 2019/10/19
- Re: [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge, Aleksandar Markovic, 2019/10/24