Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

[Philippe Mathieu-Daudé]

On 10/22/19 11:53 AM, Aleksandar Markovic wrote:
> On Friday, October 18, 2019, Philippe Mathieu-Daudé <address@hidden 
> <mailto:address@hidden>> wrote:
>
>     From: Hervé Poussineau <address@hidden
>     <mailto:address@hidden>>
>
>     Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4
>     gpio out.
>     Remove i8259 instanciated in malta board, to not have it twice.
>
>     We can also remove the now unused piix4_init() function.
>
>     Acked-by: Michael S. Tsirkin <address@hidden <mailto:address@hidden>>
>     Acked-by: Paolo Bonzini <address@hidden
>     <mailto:address@hidden>>
>     Signed-off-by: Hervé Poussineau <address@hidden
>     <mailto:address@hidden>>
>     Message-Id: <address@hidden
>     <mailto:address@hidden>>
>     Reviewed-by: Aleksandar Markovic <address@hidden
>     <mailto:address@hidden>>
>     [PMD: rebased, updated includes, use ISA_NUM_IRQS in for loop]
>     Signed-off-by: Philippe Mathieu-Daudé <address@hidden
>     <mailto:address@hidden>>
>     ---
>       hw/isa/piix4.c       | 43 ++++++++++++++++++++++++++++++++-----------
>       hw/mips/mips_malta.c | 32 +++++++++++++-------------------
>       include/hw/i386/pc.h |  1 -
>       3 files changed, 45 insertions(+), 31 deletions(-)
>
>
>
> A detail: In the title:
> Add a i8259  -> Add an i8259

OK.