Re: [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

[Markus Armbruster]

I just stumbled over this series.  It touches the QAPI visitors and even
the generator, without cc'ing its maintainers.  Such changes require
review.  There's precious little time until the soft freeze now.  I'll
try, but no promises.

Please cc me and Michael Roth <address@hidden> on future
revisions.

In general, peruse output of scripts/get_maintainer.pl to find relevant
maintainers.

Tao Xu <address@hidden> writes:

> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to the Memory Proximity Domain.
> The software is expected to use HMAT information as hint for optimization.
>
> In the linux kernel, the codes in drivers/acpi/hmat/hmat.c parse and report
> the platform's HMAT tables.
>
> The V12 patches link:
> https://patchwork.kernel.org/cover/11153861/
>
> Changelog:
> v13:
>     - Modify some text description
>     - Drop "initiator_valid" field in struct NodeInfo
>     - Reuse Garray to store the raw bandwidth and bandwidth data
>     - Calculate common base unit using range bitmap
>     - Add a patch to alculate hmat latency and bandwidth entry list
>     - Drop the total_levels option and use readable cache size
>     - Remove the unnecessary head file
>     - Use decimal notation with appropriate suffix for cache size
> v12:
>     - Fix a bug that a memory-only node without initiator setting
>       doesn't report error. (reported by Danmei Wei)
>     - Fix a bug that if HMAT is enabled and without hmat-lb setting,
>       QEMU will crash. (reported by Danmei Wei)
> v11:
>     - Move numa option patches forward.
>     - Add num_initiator in Numa_state to record the number of
>     initiators.
>     - Simplify struct HMAT_LB_Info, use uint64_t array to store data.
>     - Drop hmat_get_base().
>     - Calculate base in build_hmat_lb().
> v10:
>     - Add qemu_strtotime_ps() to convert strings with time suffixes
>     to numbers, and add some tests for it.
>     - Add qapi buildin type time, and add some tests for it.
>     - Add machine oprion properties "-machine hmat=on|off" for
>         enabling or disabling HMAT in QEMU.

I guess this is where you started messing with QAPI.  Seven weeks ago.
The time crunch is of your own making, I'm afraid.

> v9:
>     - change the CLI input way, make it more user firendly (Daniel Black)
>     use latency=NUM[p|n|u]s and bandwidth=NUM[M|G|P](B/s) as input and drop
>     the base-lat and base-bw input.
> Liu Jingqi (5):
>   numa: Extend CLI to provide memory latency and bandwidth information
>   numa: Extend CLI to provide memory side cache information
>   hmat acpi: Build Memory Proximity Domain Attributes Structure(s)
>   hmat acpi: Build System Locality Latency and Bandwidth Information
>     Structure(s)
>   hmat acpi: Build Memory Side Cache Information Structure(s)
>
> Tao Xu (7):
>   util/cutils: Add qemu_strtotime_ps()
>   tests/cutils: Add test for qemu_strtotime_ps()
>   qapi: Add builtin type time
>   tests: Add test for QAPI builtin type time
>   numa: Extend CLI to provide initiator information for numa nodes
>   numa: Calculate hmat latency and bandwidth entry list
>   tests/bios-tables-test: add test cases for ACPI HMAT
>
>  hw/acpi/Kconfig                    |   7 +-
>  hw/acpi/Makefile.objs              |   1 +
>  hw/acpi/hmat.c                     | 263 +++++++++++++++++++++++++++
>  hw/acpi/hmat.h                     |  42 +++++
>  hw/core/machine.c                  |  70 ++++++++
>  hw/core/numa.c                     | 273 ++++++++++++++++++++++++++++-
>  hw/i386/acpi-build.c               |   5 +
>  include/qapi/visitor-impl.h        |   4 +
>  include/qapi/visitor.h             |   9 +
>  include/qemu/cutils.h              |   1 +
>  include/sysemu/numa.h              | 104 +++++++++++
>  qapi/machine.json                  | 179 ++++++++++++++++++-
>  qapi/opts-visitor.c                |  22 +++
>  qapi/qapi-visit-core.c             |  12 ++
>  qapi/qobject-input-visitor.c       |  18 ++
>  qapi/trace-events                  |   1 +
>  qemu-options.hx                    |  96 +++++++++-
>  scripts/qapi/common.py             |   1 +
>  tests/bios-tables-test.c           |  44 +++++
>  tests/test-cutils.c                | 199 +++++++++++++++++++++
>  tests/test-keyval.c                | 125 +++++++++++++
>  tests/test-qobject-input-visitor.c |  29 +++
>  util/cutils.c                      |  82 +++++++++
>  23 files changed, 1575 insertions(+), 12 deletions(-)
>  create mode 100644 hw/acpi/hmat.c
>  create mode 100644 hw/acpi/hmat.h