qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] translate-all: fix uninitialized tb->orig_tb


From: Clement Deschamps
Subject: [PATCH] translate-all: fix uninitialized tb->orig_tb
Date: Tue, 22 Oct 2019 16:00:16 +0200

This fixes a segmentation fault in icount mode when executing from an IO region.

TB is marked as CF_NOCACHE but tb->orig_tb is not initialized (equals
previous value in code_gen_buffer).

The issue happens in cpu_io_recompile() when it tries to invalidate orig_tb.

Signed-off-by: Clement Deschamps <address@hidden>
---
 accel/tcg/translate-all.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 66d4bc4341..f9b7ba159d 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1722,6 +1722,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
     tb->cs_base = cs_base;
     tb->flags = flags;
     tb->cflags = cflags;
+    tb->orig_tb = NULL;
     tb->trace_vcpu_dstate = *cpu->trace_dstate;
     tcg_ctx->tb_cflags = cflags;
  tb_overflow:
-- 
2.23.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]