[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state |
|
Date: |
Wed, 23 Oct 2019 16:17:26 +0100 |
|
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Richard Henderson <address@hidden> writes:
> On 10/22/19 11:38 AM, Peter Maydell wrote:
>> Turns out this asserts in qemu-armeb :-(
>>
>> /home/petmay01/linaro/qemu-for-merges/build/all-linux-static/armeb-linux-user/qemu-armeb
>> -L ./gnemul/qemu-armeb armeb/ls -l dummyfile
>> qemu-armeb: /home/petmay01/linaro/qemu-for-merges/target/arm/helper.c:11267:
>> cpu_get_tb_cpu_state: Assertion `flags ==
>> rebuild_hflags_internal(env)' failed.
>> qemu: uncaught target signal 11 (Segmentation fault) - core dumped
>> Segmentation fault (core dumped)
>>
>> Dropping this series again for the moment.
> Argh! I had forgotten that we have no testing of armeb in check-tcg.
Does it need it's own toolchain or can it be done with flags?
>
> Yes, I see now that we need a recompute in linux-user/{aarch64,arm}/cpu_loop.c
> specific to TARGET_WORDS_BIGENDIAN.
>
>
> r~
--
Alex Bennée
- [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes, (continued)
- [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes, Richard Henderson, 2019/10/18
- [PATCH v8 17/22] target/arm: Rebuild hflags at MSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes, Richard Henderson, 2019/10/18
- [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes, Richard Henderson, 2019/10/18
- [PATCH v8 20/22] target/arm: Rebuild hflags for M-profile, Richard Henderson, 2019/10/18
- [PATCH v8 21/22] target/arm: Rebuild hflags for M-profile NVIC, Richard Henderson, 2019/10/18
- [PATCH v8 22/22] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state, Richard Henderson, 2019/10/18
- Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state, Peter Maydell, 2019/10/22