qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 22/39] checkpatch: suggest qemu_real_host_page_size instead of get


From: Paolo Bonzini
Subject: [PULL 22/39] checkpatch: suggest qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)
Date: Thu, 24 Oct 2019 16:03:38 +0200

From: Wei Yang <address@hidden>

Signed-off-by: Wei Yang <address@hidden>
CC: Richard Henderson <address@hidden>
CC: Stefan Hajnoczi <address@hidden>

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index aa9a354..ab68a16 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2915,6 +2915,12 @@ sub process {
                if ($line =~ /\bbzero\(/) {
                        ERROR("use memset() instead of bzero()\n" . $herecurr);
                }
+               if ($line =~ /\bgetpagesize\(\)/) {
+                       ERROR("use qemu_real_host_page_size instead of 
getpagesize()\n" . $herecurr);
+               }
+               if ($line =~ /\bsysconf\(_SC_PAGESIZE\)/) {
+                       ERROR("use qemu_real_host_page_size instead of 
sysconf(_SC_PAGESIZE)\n" . $herecurr);
+               }
                my $non_exit_glib_asserts = qr{g_assert_cmpstr|
                                                g_assert_cmpint|
                                                g_assert_cmpuint|
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]