Re: [PATCH v2 15/17] travis.yml: --enable-debug-tcg to check-tcg

[Alex Bennée]

Philippe Mathieu-Daudé <address@hidden> writes:

> On Thu, Oct 24, 2019 at 4:33 PM Philippe Mathieu-Daudé
> <address@hidden> wrote:
>> On 10/24/19 12:22 PM, Alex Bennée wrote:
>> > This adds a whole bunch of asserts which will catch bugs you might
>> > introduce into the TCG code.
>>
>> Very good idea.
>>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>
>> >
>> > Signed-off-by: Alex Bennée <address@hidden>
>> > ---
>> >   .travis.yml | 4 ++--
>> >   1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/.travis.yml b/.travis.yml
>> > index c43597f1331..ba3a8d4cfc9 100644
>> > --- a/.travis.yml
>> > +++ b/.travis.yml
>> > @@ -334,14 +334,14 @@ matrix:
>> >
>> >       # Run check-tcg against linux-user
>> >       - env:
>> > -        - CONFIG="--disable-system"
>> > +        - CONFIG="--disable-system --enable-debug-tcg"
>> >           - TEST_CMD="make -j3 check-tcg V=1"
>> >           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>
> Hmm maybe we should change the ccache name now...
>
> CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"?

I've sent a patch that applies to my currently brewing PR.

>
>> >
>> >
>> >       # Run check-tcg against softmmu targets
>> >       - env:
>> > -        - 
>> > CONFIG="--target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu"
>> > +        - CONFIG="--enable-debug-tcg 
>> > --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu"
>> >           - TEST_CMD="make -j3 check-tcg V=1"
>> >           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>
> Here too.


--
Alex Bennée