Re: [PULL 00/11] MIPS queue for October 24th, 2019

[Peter Maydell]

On Thu, 24 Oct 2019 at 12:07, Aleksandar Markovic
<address@hidden> wrote:
>
> From: Aleksandar Markovic <address@hidden>
>
> The following changes since commit ea0ec714d3109e0d0523b9dacb38030e4cb142a8:
>
>   Merge remote-tracking branch 'remotes/xtensa/tags/20191023-xtensa' into 
> staging (2019-10-24 09:55:01 +0100)
>
> are available in the git repository at:
>
>   https://github.com/AMarkovic/qemu tags/mips-queue-oct-24-2019
>
> for you to fetch changes up to f4d200d0e55ebc4e9c9af50cb9317e2f6ebe9d0c:
>
>   target/mips: Add support for emulation of CRC32 group of instructions 
> (2019-10-24 13:00:37 +0200)
>
> ----------------------------------------------------------------
>
> MIPS queue for October 24th, 2019
>
>   - added emulation of R6 CRC32 instructions
>   - added several mostly cosmetic leanups
>   - a checkpath warning is a false positive
>

Hi; this fails to compile with 'implicit conversion' errors
on clang (OSX, freebsd, openbsd, and linux):


/home/petmay01/linaro/qemu-for-merges/target/mips/op_helper.c:359:44:
error: implicit conversion from 'unsigned long long' to 'target_ulong'
(aka 'unsigned int') changes value from 18446744073709551615 to
4294967295 [-Werror,-Wconstant-conversion]
    target_ulong mask = ((sz * 8) == 64) ? -1ULL : ((1ULL << (sz * 8)) - 1);
                 ~~~~                      ^~~~~
/home/petmay01/linaro/qemu-for-merges/target/mips/op_helper.c:369:44:
error: implicit conversion from 'unsigned long long' to 'target_ulong'
(aka 'unsigned int') changes value from 18446744073709551615 to
4294967295 [-Werror,-Wconstant-conversion]
    target_ulong mask = ((sz * 8) == 64) ? -1ULL : ((1ULL << (sz * 8)) - 1);
                 ~~~~                      ^~~~~
2 errors generated.


thanks
-- PMM