Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

[Peter Maydell]

On Thu, 24 Oct 2019 at 15:21, Paolo Bonzini <address@hidden> wrote:
>
> The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9:
>
>   Merge remote-tracking branch 
> 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 
> 14:13:11 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to a263f81cb4b302eb392898bdc4ad4381e1961629:
>
>   i386: implement IGNNE (2019-10-24 16:02:04 +0200)
>
> ----------------------------------------------------------------
> * Bulgarian translation update (Alexander)
> * RTC and PC refactorings (Hervé, Philippe, Sergio)
> * RTC fix (Marcelo)
> * More comprehensive MCE logging (Mario)
> * x86 IGNNE implementation (Paolo)
> * Microvm machine type (Sergio)
> * Support for UMONITOR/UMWAIT/TPAUSE (Tao)
> * Do not use %m in common code (Thomas)
> * NoNonArchitecturalCoreSharing Hyper-V enlightenment (Vitaly)
> * getpagesize cleanups (Wei)
>

I got a link failure building the --disable-tcg config on x86-64:


  LINK    x86_64-softmmu/qemu-system-x86_64
hw/i386/pc_piix.o: In function `pc_init1':
/home/petmay01/linaro/qemu-for-merges/hw/i386/pc_piix.c:216: undefined
reference to `x86_register_ferr_irq'
hw/i386/pc_q35.o: In function `pc_q35_init':
/home/petmay01/linaro/qemu-for-merges/hw/i386/pc_q35.c:264: undefined
reference to `x86_register_ferr_irq'
collect2: error: ld returned 1 exit status
Makefile:206: recipe for target 'qemu-system-x86_64' failed
make[1]: *** [qemu-system-x86_64] Error 1
Makefile:482: recipe for target 'x86_64-softmmu/all' failed
make: *** [x86_64-softmmu/all] Error 2
make: *** Waiting for unfinished jobs....
  LINK    i386-softmmu/qemu-system-i386
hw/i386/pc_piix.o: In function `pc_init1':
/home/petmay01/linaro/qemu-for-merges/hw/i386/pc_piix.c:216: undefined
reference to `x86_register_ferr_irq'
hw/i386/pc_q35.o: In function `pc_q35_init':
/home/petmay01/linaro/qemu-for-merges/hw/i386/pc_q35.c:264: undefined
reference to `x86_register_ferr_irq'
collect2: error: ld returned 1 exit status


x86_register_ferr_irq() is defined in target/i386/fpu_helper.c,
which is only built if CONFIG_TCG, but the callers don't
seem to be similarly guarded and there's no stub fallback.

thanks
-- PMM