[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/targe
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h |
Date: |
Fri, 25 Oct 2019 14:09:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
Le 25/10/2019 à 13:39, Richard Henderson a écrit :
> This fixes a naming bug wherein we used "UREG_FP" to access the
> stack pointer. OTOH, the "UREG_FP" constant was also defined
> incorrectly such that it *did* reference the stack pointer.
>
> Note that the kernel legitimately uses the name "FP", because it
> utilizes the rolled stack window in processing the system call.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> linux-user/sparc/target_cpu.h | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
> index 1ffc0ae9f2..b30fbc72c4 100644
> --- a/linux-user/sparc/target_cpu.h
> +++ b/linux-user/sparc/target_cpu.h
> @@ -41,15 +41,9 @@ static inline void cpu_set_tls(CPUSPARCState *env,
> target_ulong newtls)
> env->gregs[7] = newtls;
> }
>
> -#ifndef UREG_I6
> -#define UREG_I6 6
> -#endif
> -#ifndef UREG_FP
> -#define UREG_FP UREG_I6
> -#endif
> -
> static inline abi_ulong get_sp_from_cpustate(CPUSPARCState *state)
> {
> - return state->regwptr[UREG_FP];
> + return state->regwptr[WREG_SP];
> }
> +
> #endif
>
Reviewed-by: Laurent Vivier <address@hidden>
- [PATCH v2 00/12] linux-user sparc fixes, Richard Henderson, 2019/10/25
- [PATCH v2 01/12] scripts/qemu-binfmt-conf: Update for sparc64, Richard Henderson, 2019/10/25
- [PATCH v2 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat, Richard Henderson, 2019/10/25
- [PATCH v2 07/12] linux-user/sparc: Fix WREG usage in setup_frame, Richard Henderson, 2019/10/25
- [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h, Richard Henderson, 2019/10/25
- Re: [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h,
Laurent Vivier <=
- [PATCH v2 08/12] linux-user/sparc64: Fix target_signal_frame, Richard Henderson, 2019/10/25
- [PATCH v2 03/12] target/sparc: Define an enumeration for accessing env->regwptr, Richard Henderson, 2019/10/25
- [PATCH v2 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Richard Henderson, 2019/10/25
- [PATCH v2 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c, Richard Henderson, 2019/10/25
- [PATCH v2 12/12] linux-user/alpha: Set r20 secondary return value, Richard Henderson, 2019/10/25