Re: [PATCH v2 00/12] linux-user sparc fixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 00/12] linux-user sparc fixes
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
10a58e6 linux-user/alpha: Set r20 secondary return value
5eb8e13 linux-user/sparc: Fix cpu_clone_regs_*
1fe4085 linux-user: Introduce cpu_clone_regs_parent
c6bf6f2 linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
1e0a916 linux-user/sparc64: Fix target_signal_frame
b250d74 linux-user/sparc: Fix WREG usage in setup_frame
a8508ed linux-user/sparc: Use WREG_SP constant in sparc/signal.c
9b12e1c linux-user/sparc: Begin using WREG constants in sparc/signal.c
0da4e3e linux-user/sparc: Use WREG constants in sparc/target_cpu.h
2bab940 target/sparc: Define an enumeration for accessing env->regwptr
dfc8869 tests/tcg/multiarch/linux-test: Fix error check for shmat
32ef6cd scripts/qemu-binfmt-conf: Update for sparc64

=== OUTPUT BEGIN ===
1/12 Checking commit 32ef6cd7742f (scripts/qemu-binfmt-conf: Update for sparc64)
WARNING: line over 80 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:41:
+sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'

ERROR: line over 90 characters
#35: FILE: scripts/qemu-binfmt-conf.sh:42:
+sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 1 errors, 1 warnings, 20 lines checked

Patch 1/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/12 Checking commit dfc8869ba150 (tests/tcg/multiarch/linux-test: Fix error 
check for shmat)
3/12 Checking commit 2bab94043648 (target/sparc: Define an enumeration for 
accessing env->regwptr)
4/12 Checking commit 0da4e3e1f98e (linux-user/sparc: Use WREG constants in 
sparc/target_cpu.h)
5/12 Checking commit 9b12e1c8e388 (linux-user/sparc: Begin using WREG constants 
in sparc/signal.c)
ERROR: spaces required around that '+' (ctx:VxV)
#49: FILE: linux-user/sparc/signal.c:151:
+        __put_user(env->regwptr[WREG_O0 + i], &si->si_regs.u_regs[i+8]);
                                                                    ^

ERROR: spaces required around that '+' (ctx:VxV)
#121: FILE: linux-user/sparc/signal.c:290:
+        __get_user(env->regwptr[i + WREG_O0], &sf->info.si_regs.u_regs[i+8]);
                                                                         ^

ERROR: spaces required around that '+' (ctx:VxV)
#168: FILE: linux-user/sparc/signal.c:460:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#203: FILE: linux-user/sparc/signal.c:563:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
                               ^

total: 4 errors, 0 warnings, 175 lines checked

Patch 5/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/12 Checking commit a8508ed3e8ff (linux-user/sparc: Use WREG_SP constant in 
sparc/signal.c)
7/12 Checking commit b250d74fed90 (linux-user/sparc: Fix WREG usage in 
setup_frame)
8/12 Checking commit 1e0a916d1fca (linux-user/sparc64: Fix target_signal_frame)
ERROR: space prohibited between function name and open parenthesis '('
#21: FILE: linux-user/sparc/signal.c:90:
+    uint32_t            insns[2] __attribute__ ((aligned (8)));

total: 1 errors, 0 warnings, 16 lines checked

Patch 8/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/12 Checking commit c6bf6f2ab73f (linux-user: Rename cpu_clone_regs to 
cpu_clone_regs_child)
10/12 Checking commit 1fe40851fad6 (linux-user: Introduce cpu_clone_regs_parent)
11/12 Checking commit 5eb8e1397a6b (linux-user/sparc: Fix cpu_clone_regs_*)
12/12 Checking commit 10a58e689746 (linux-user/alpha: Set r20 secondary return 
value)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden