[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 00/12] tcg patch queue
From: |
no-reply |
Subject: |
Re: [PULL v2 00/12] tcg patch queue |
Date: |
Mon, 28 Oct 2019 10:20:07 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL v2 00/12] tcg patch queue
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dddd2c9 translate-all: Remove tb_alloc
ce663b2 translate-all: fix uninitialized tb->orig_tb
90c3eba cputlb: Fix tlb_vaddr_to_host
d2b8cbd exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY
4ce23d0 exec: Promote TARGET_PAGE_MASK to target_long
7d2699f exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG
b5f712d exec: Use const alias for TARGET_PAGE_BITS_VARY
8d1e9d0 configure: Detect compiler support for __attribute__((alias))
cad9025 exec: Split out variable page size support to exec-vary.c
b290db4 cpu: use ROUND_UP() to define xxx_PAGE_ALIGN
60dbf14 cputlb: ensure _cmmu helper functions follow the naming standard
cdaeeaf tci: Add implementation for INDEX_op_ld16u_i64
=== OUTPUT BEGIN ===
1/12 Checking commit cdaeeaf401d2 (tci: Add implementation for
INDEX_op_ld16u_i64)
2/12 Checking commit 60dbf140a9ab (cputlb: ensure _cmmu helper functions follow
the naming standard)
3/12 Checking commit b290db446298 (cpu: use ROUND_UP() to define xxx_PAGE_ALIGN)
4/12 Checking commit cad9025d89cb (exec: Split out variable page size support
to exec-vary.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 125 lines checked
Patch 4/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/12 Checking commit 8d1e9d07c296 (configure: Detect compiler support for
__attribute__((alias)))
6/12 Checking commit b5f712d02e4f (exec: Use const alias for
TARGET_PAGE_BITS_VARY)
ERROR: externs should be avoided in .c files
#66: FILE: exec-vary.c:57:
+extern const TargetPageBits target_page
total: 1 errors, 0 warnings, 109 lines checked
Patch 6/12 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit 7d2699f55dd2 (exec: Restrict TARGET_PAGE_BITS_VARY assert
to CONFIG_DEBUG_TCG)
8/12 Checking commit 4ce23d02a238 (exec: Promote TARGET_PAGE_MASK to
target_long)
9/12 Checking commit d2b8cbd91572 (exec: Cache TARGET_PAGE_MASK for
TARGET_PAGE_BITS_VARY)
10/12 Checking commit 90c3eba34f5f (cputlb: Fix tlb_vaddr_to_host)
11/12 Checking commit ce663b281c78 (translate-all: fix uninitialized
tb->orig_tb)
12/12 Checking commit dddd2c942dd5 (translate-all: Remove tb_alloc)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PULL v2 05/12] configure: Detect compiler support for __attribute__((alias)), (continued)
- [PULL v2 05/12] configure: Detect compiler support for __attribute__((alias)), Richard Henderson, 2019/10/28
- [PULL v2 08/12] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/10/28
- [PULL v2 09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 10/12] cputlb: Fix tlb_vaddr_to_host, Richard Henderson, 2019/10/28
- [PULL v2 01/12] tci: Add implementation for INDEX_op_ld16u_i64, Richard Henderson, 2019/10/28
- [PULL v2 03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN, Richard Henderson, 2019/10/28
- [PULL v2 06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/10/28
- [PULL v2 12/12] translate-all: Remove tb_alloc, Richard Henderson, 2019/10/28
- [PULL v2 07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/10/28
- [PULL v2 11/12] translate-all: fix uninitialized tb->orig_tb, Richard Henderson, 2019/10/28
- Re: [PULL v2 00/12] tcg patch queue,
no-reply <=
- Re: [PULL v2 00/12] tcg patch queue, Peter Maydell, 2019/10/29