Re: [PATCH 15/26] tests/acceptance: Test OpenBIOS on the PReP/40p

[Cleber Rosa]

On Mon, Oct 28, 2019 at 02:41:51PM -0400, Cleber Rosa wrote:
> On Mon, Oct 28, 2019 at 08:34:30AM +0100, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daudé <address@hidden>
> > 
> > User case from:
> > https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
> > 
> > Acked-by: David Gibson <address@hidden>
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > v3:
> > - use avocado_qemu.wait_for_console_pattern (Cleber)
> > - use MD5 hash
> > ---
> 
> Reviewed-by: Cleber Rosa <address@hidden>
> Tested-by: Cleber Rosa <address@hidden>
> 
> Queuing on my python-next branch (and sending shortly in a PR).

Even though this test runs fine on my local machine, it times out
under Travis because the image is too large to be downloaded within
the test timeout.  For now, I'm adding:

   @skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')

The definitive solution is coming.  Avocado master already allows one to
run:

   $ avocado assets fetch tests/acceptance/boot_linux_console.py

And have the assets downloaded *before* the test is executed.  We're now
adding a "pre_tests"[1] plugin, so that the download will be done
automatically (and only for the tests in the current job).

- Cleber.

[1] - 
https://avocado-framework.readthedocs.io/en/72.0/api/core/avocado.core.html#avocado.core.plugin_interfaces.JobPreTests

> 
> Thanks,
> - Cleber.