[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/3] tests/vm: netbsd autoinstall, using serial console
From: |
Alex Bennée |
Subject: |
Re: [PATCH v5 1/3] tests/vm: netbsd autoinstall, using serial console |
Date: |
Tue, 29 Oct 2019 12:06:48 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Thomas Huth <address@hidden> writes:
> On 18/10/2019 20.17, Eduardo Habkost wrote:
>> From: Gerd Hoffmann <address@hidden>
>>
>> Instead of fetching the prebuilt image from patchew download the install
>> iso and prepare the image locally. Install to disk, using the serial
>> console. Create qemu user, configure ssh login. Install packages
>> needed for qemu builds.
>>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
>> Reviewed-by: Kamil Rytarowski <address@hidden>
>> Tested-by: Thomas Huth <address@hidden>
>> [ehabkost: rebased to latest qemu.git master]
>> Signed-off-by: Eduardo Habkost <address@hidden>
>> ---
>> tests/vm/netbsd | 189 +++++++++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 179 insertions(+), 10 deletions(-)
>>
>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
>> index ee9eaeab50..49a99477f4 100755
>> --- a/tests/vm/netbsd
>> +++ b/tests/vm/netbsd
>> @@ -2,10 +2,11 @@
>> #
>> # NetBSD VM image
>> #
>> -# Copyright 2017 Red Hat Inc.
>> +# Copyright 2017-2019 Red Hat Inc.
>> #
>> # Authors:
>> # Fam Zheng <address@hidden>
>> +# Gerd Hoffmann <address@hidden>
>> #
>> # This code is licensed under the GPL version 2 or later. See
>> # the COPYING file in the top-level directory.
>> @@ -13,30 +14,198 @@
>>
>> import os
>> import sys
>> +import time
>> import subprocess
>> import basevm
>>
>> class NetBSDVM(basevm.BaseVM):
>> name = "netbsd"
>> arch = "x86_64"
>> +
>> + link =
>> "https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.0/images/NetBSD-8.0-amd64.iso"
>
> I'd like to suggest to go immediately with 8.1 instead of 8.0. I tested
> it and it worked for me out-of-the-box, without further modifications.
*Sigh* I had to drop this from my PR after it broke again. It looked
like it was getting stuck on the installer waiting for something. I had
it working at one point so I'm not sure why it's not working again.
The rest of the patches are merged now though.
>
>> +
>> + if os.path.exists(img):
>> + os.remove(img)
>
> These two lines have been removed recently with commit
> fcd2060e8efff83b7bdef04323077f87e011fdc4 ... please drop them from the
> patch.
>
> Thanks,
> Thomas
--
Alex Bennée
- [PATCH v5 0/3] tests/vm: netbsd autoinstall, with IPv6 disabled, Eduardo Habkost, 2019/10/18
- [PATCH v5 1/3] tests/vm: netbsd autoinstall, using serial console, Eduardo Habkost, 2019/10/18
- [PATCH v5 2/3] tests/vm: Let subclasses disable IPv6, Eduardo Habkost, 2019/10/18
- [PATCH v5 3/3] tests/vm/netbsd: Disable IPv6, Eduardo Habkost, 2019/10/18
- Re: [PATCH v5 0/3] tests/vm: netbsd autoinstall, with IPv6 disabled, Alex Bennée, 2019/10/21