Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

[Aleksandar Markovic]

On Tuesday, October 29, 2019, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Aleksandar,
>
> On 10/29/19 6:18 AM, Aleksandar Markovic wrote:
> > On Monday, October 28, 2019, Philippe Mathieu-Daudé <address@hidden <mailto:address@hidden>> wrote:
> >
> >     Hi Peter,
> >
> >     This is a X86/MIPS pull, Paolo and Aleksandar are OK I send it:
> >
> >     https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04959.html
> >     <https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04959.html>
> >
> >     Regards,
> >
> >     Phil.
> >
> >
> > Does this pull request apply on the current code base directly, or is dependant on prior application of other pull requests?
>
> I'm not sure I understand the question, this is a pull request, so it has been tested on the commit on the last master commit (yesterday),
> the cover says commit '9bb7350232'. Is there a problem?

My question was crystal clear, I can't believe you couldn't understand it.

There is no problem in that case (if your request applies on the master at the moment of the submission),, but you for unknown reason mentioned in another message that you plan to submit your pull request AFTER merging Paolo's pull request, creating a confusion whether these pull request depend each on another.

I am happy if this pull request is finally merged.

I supported this series from the outset, and I still support it, and think it is a truly valuable reorganization of involved QEMU segment, and I salute its integration. But I did not like the process of integration that I thought would be a smooth sailing, but because of surrounding self-imposed circumstances, it became at times very rocky road. I advise you that, in future, you try to do one thing at the time, and I think you can achieve far more that way, even if this does not look that way at furst glance.

Still, you deserve all kudos for the series!

Yours,

Aleksandar

 

> >     The following changes since commit
> >     9bb73502321d46f4d320fa17aa38201445783fc4:
> >
> >        Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> >     staging (2019-10-28 13:32:40 +0000)
> >
> >     are available in the Git repository at:
> >
> >     https://gitlab.com/philmd/qemu.git
> >     <https://gitlab.com/philmd/qemu.git>
> >     tags/pc_split_i440fx_piix-pull-request
> >
> >     for you to fetch changes up to d1389352cde824ce8dab7c1a2ded150df6add124:
> >
> >        hw/pci-host/i440fx: Remove the last PIIX3 traces (2019-10-28
> >     16:12:29 +0100)
> >
> >     ----------------------------------------------------------------
> >     The i440FX northbridge is only used by the PC machine, while the
> >     PIIX southbridge is also used by the Malta MIPS machine.
> >
> >     Split the PIIX3 southbridge from i440FX northbridge.
> >
> >     ----------------------------------------------------------------
> >
> >     Hervé Poussineau (5):
> >        piix4: Add the Reset Control Register
> >        piix4: Add an i8259 Interrupt Controller as specified in datasheet
> >        piix4: Rename PIIX4 object to piix4-isa
> >        piix4: Add an i8257 DMA Controller as specified in datasheet
> >        piix4: Add an i8254 PIT Controller as specified in datasheet
> >
> >     Philippe Mathieu-Daudé (15):
> >        MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets
> >        Revert "irq: introduce qemu_irq_proxy()"
> >        piix4: Add a MC146818 RTC Controller as specified in datasheet
> >        hw/mips/mips_malta: Create IDE hard drive array dynamically
> >        hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()
> >        hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c
> >        hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers
> >        hw/pci-host/piix: Extract piix3_create()
> >        hw/pci-host/piix: Move RCR_IOPORT register definition
> >        hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers
> >        hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h
> >        hw/pci-host/piix: Fix code style issues
> >        hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c
> >        hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'
> >        hw/pci-host/i440fx: Remove the last PIIX3 traces
> >
> >       MAINTAINERS                      |  14 +-
> >       hw/acpi/pcihp.c                  |   2 +-
> >       hw/acpi/piix4.c                  |  42 +--
> >       hw/core/irq.c                    |  14 -
> >       hw/i386/Kconfig                  |   3 +-
> >       hw/i386/acpi-build.c             |   5 +-
> >       hw/i386/pc_piix.c                |  10 +-
> >       hw/i386/xen/xen-hvm.c            |   5 +-
> >       hw/intc/apic_common.c            |  49 ----
> >       hw/isa/Kconfig                   |   4 +
> >       hw/isa/Makefile.objs             |   1 +
> >       hw/isa/piix3.c                   | 399 +++++++++++++++++++++++++++++
> >       hw/isa/piix4.c                   | 151 ++++++++++-
> >       hw/mips/gt64xxx_pci.c            |   5 +-
> >       hw/mips/mips_malta.c             |  46 +---
> >       hw/pci-host/Kconfig              |   3 +-
> >       hw/pci-host/Makefile.objs        |   2 +-
> >       hw/pci-host/{piix.c => i440fx.c} | 424 +------------------------------
> >       hw/timer/i8254_common.c          |  40 ---
> >       include/hw/acpi/piix4.h          |   6 -
> >       include/hw/i386/pc.h             |  37 ---
> >       include/hw/irq.h                 |   5 -
> >       include/hw/isa/isa.h             |   2 +
> >       include/hw/pci-host/i440fx.h     |  36 +++
> >       include/hw/southbridge/piix.h    |  74 ++++++
> >       stubs/pci-host-piix.c            |   3 +-
> >       26 files changed, 699 insertions(+), 683 deletions(-)
> >       create mode 100644 hw/isa/piix3.c
> >       rename hw/pci-host/{piix.c => i440fx.c} (58%)
> >       delete mode 100644 include/hw/acpi/piix4.h
> >       create mode 100644 include/hw/pci-host/i440fx.h
> >       create mode 100644 include/hw/southbridge/piix.h
> >
> >     --     2.21.0