[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUS
From: |
Max Reitz |
Subject: |
Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER |
Date: |
Mon, 4 Nov 2019 13:57:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 26.10.19 23:25, Alberto Garcia wrote:
> In the previous patch we added a new QCow2ClusterType named
> QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER. There is a couple of places
> where this new value needs to be handled, and that is what this patch
> does.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/qcow2.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
This patch deals with everything in qcow2.c. There are more places that
reference QCOW2_CLUSTER_* constants elsewhere, and I suppose most of
them are handled by the following patches.
But I wonder what the criterion is on where it needs to be handled and
where it’s OK not to. Right now it looks to me like it’s a bit
arbitrary maybe? But I suppose I’ll just have to wait until after the
next patches.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER,
Max Reitz <=