[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat
From: |
Laurent Vivier |
Subject: |
[PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat |
Date: |
Tue, 5 Nov 2019 19:11:09 +0100 |
From: Richard Henderson <address@hidden>
The error indicator for this syscall is -1, not 0.
Fixes: e374bfa35bfb ("shm tests - disabled clone test")
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
tests/tcg/multiarch/linux-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index fa4243fc0426..673d7c8a1c25 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -503,8 +503,9 @@ static void test_shm(void)
shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
ptr = shmat(shmid, NULL, 0);
- if (!ptr)
+ if (ptr == (void *)-1) {
error("shmat");
+ }
memset(ptr, 0, SHM_SIZE);
--
2.21.0
- [PULL 00/13] Linux user for 4.2 patches, Laurent Vivier, 2019/11/05
- [PULL 13/13] linux-user/alpha: Set r20 secondary return value, Laurent Vivier, 2019/11/05
- [PULL 01/13] linux-user: Support for NETLINK socket options, Laurent Vivier, 2019/11/05
- [PULL 10/13] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child, Laurent Vivier, 2019/11/05
- [PULL 07/13] linux-user/sparc: Use WREG_SP constant in sparc/signal.c, Laurent Vivier, 2019/11/05
- [PULL 02/13] scripts/qemu-binfmt-conf: Update for sparc64, Laurent Vivier, 2019/11/05
- [PULL 09/13] linux-user/sparc64: Fix target_signal_frame, Laurent Vivier, 2019/11/05
- [PULL 06/13] linux-user/sparc: Begin using WREG constants in sparc/signal.c, Laurent Vivier, 2019/11/05
- [PULL 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h, Laurent Vivier, 2019/11/05
- [PULL 04/13] target/sparc: Define an enumeration for accessing env->regwptr, Laurent Vivier, 2019/11/05
- [PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat,
Laurent Vivier <=
- [PULL 12/13] linux-user/sparc: Fix cpu_clone_regs_*, Laurent Vivier, 2019/11/05
- [PULL 08/13] linux-user/sparc: Fix WREG usage in setup_frame, Laurent Vivier, 2019/11/05
- [PULL 11/13] linux-user: Introduce cpu_clone_regs_parent, Laurent Vivier, 2019/11/05
- Re: [PULL 00/13] Linux user for 4.2 patches, no-reply, 2019/11/05