[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string opti
|
From: |
Liu, Yi L |
|
Subject: |
RE: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string option |
|
Date: |
Wed, 6 Nov 2019 09:50:38 +0000 |
> From: Peter Xu [mailto:address@hidden]
> Sent: Tuesday, November 5, 2019 8:50 PM
> To: Liu, Yi L <address@hidden>
> Subject: Re: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string
> option
>
> On Tue, Nov 05, 2019 at 09:14:08AM +0000, Liu, Yi L wrote:
> > > Something like:
> > >
> > > - s->scalable_mode_str to keep the string
> > > - s->scalable_mode still as a bool to cache the global enablement
> > > - s->scalable_modern as a bool to keep the mode
> > >
> > > ?
> >
> > So x-scalable-mode is still a string option, just to have a new field to
> > store it?
>
> Yep. I'd say maybe we should start to allow to define some union-ish
> properties, but
> for now I think string is ok.
ok, let me make it in next version.
Thanks,
Yi Liu