[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jm
From: |
Luc Michel |
Subject: |
Re: [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp() |
Date: |
Wed, 6 Nov 2019 15:42:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 11/6/19 3:14 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Plug temp leak around eval_cond_jmp().
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
> target/microblaze/translate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index e9ff9e650d..93e22a89ac 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1705,7 +1705,10 @@ void gen_intermediate_code(CPUState *cs,
> TranslationBlock *tb, int max_insns)
> dc->tb_flags &= ~D_FLAG;
> /* If it is a direct jump, try direct chaining. */
> if (dc->jmp == JMP_INDIRECT) {
> - eval_cond_jmp(dc, env_btarget, tcg_const_i64(dc->pc));
> + TCGv_i64 tmp_pc = tcg_const_i64(dc->pc);
> + eval_cond_jmp(dc, env_btarget, tmp_pc);
> + tcg_temp_free_i64(tmp_pc);
> +
> dc->is_jmp = DISAS_JUMP;
> } else if (dc->jmp == JMP_DIRECT) {
> t_sync_flags(dc);
>
Reviewed-by: Luc Michel <address@hidden>
- Re: [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores, (continued)