[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Patch v2 1/6] migration/postcopy: reduce memset when it is zero page an
From: |
Wei Yang |
Subject: |
[Patch v2 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size |
Date: |
Thu, 7 Nov 2019 20:39:02 +0800 |
In this case, page_buffer content would not be used.
Skip this to save some time.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/ram.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 99a98b2da4..7938a643d9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4091,7 +4091,13 @@ static int ram_load_postcopy(QEMUFile *f)
switch (flags & ~RAM_SAVE_FLAG_CONTINUE) {
case RAM_SAVE_FLAG_ZERO:
ch = qemu_get_byte(f);
- memset(page_buffer, ch, TARGET_PAGE_SIZE);
+ /*
+ * Can skip to set page_buffer when
+ * this is a zero page and (block->page_size == TARGET_PAGE_SIZE).
+ */
+ if (ch || !matches_target_page_size) {
+ memset(page_buffer, ch, TARGET_PAGE_SIZE);
+ }
if (ch) {
all_zero = false;
}
--
2.17.1
- [Patch v2 0/6] migration/postcopy: enable compress during postcopy, Wei Yang, 2019/11/07
- [Patch v2 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size,
Wei Yang <=
- [Patch v2 3/6] migration/postcopy: count target page number to decide the place_needed, Wei Yang, 2019/11/07
- [Patch v2 4/6] migration/postcopy: set all_zero to true on the first target page, Wei Yang, 2019/11/07
- [Patch v2 2/6] migration/postcopy: wait for decompress thread in precopy, Wei Yang, 2019/11/07
- [Patch v2 5/6] migration/postcopy: enable random order target page arrival, Wei Yang, 2019/11/07
- [Patch v2 6/6] migration/postcopy: enable compress during postcopy, Wei Yang, 2019/11/07