[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Make the qemu_logfile handle thread safe.
From: |
Alex Bennée |
Subject: |
Re: [PATCH 0/4] Make the qemu_logfile handle thread safe. |
Date: |
Thu, 07 Nov 2019 16:35:48 +0000 |
User-agent: |
mu4e 1.3.5; emacs 27.0.50 |
Robert Foley <address@hidden> writes:
> This patch adds thread safety to the qemu_logfile handle. This now
> allows changing the logfile while logging is active, and also solves
> the issue of a seg fault while changing the logfile.
>
> This patch adds use of RCU for handling the swap out of the
> old qemu_logfile file descriptor.
I've finished my pass. Looks pretty good - a few minor comments around
the persistence of the read lock and some minor stylistic nits.
>
> Robert Foley (4):
> Add a mutex to guarantee single writer to qemu_logfile handle.
> Add use of RCU for qemu_logfile.
> qemu_log_lock/unlock now preserves the qemu_logfile handle.
> Added tests for close and change of logfile.
>
> accel/tcg/cpu-exec.c | 4 +-
> accel/tcg/translate-all.c | 4 +-
> accel/tcg/translator.c | 4 +-
> exec.c | 4 +-
> hw/net/can/can_sja1000.c | 4 +-
> include/exec/log.h | 33 ++++++++++--
> include/qemu/log.h | 51 +++++++++++++++---
> net/can/can_socketcan.c | 5 +-
> target/cris/translate.c | 4 +-
> target/i386/translate.c | 5 +-
> target/lm32/translate.c | 4 +-
> target/microblaze/translate.c | 4 +-
> target/nios2/translate.c | 4 +-
> target/tilegx/translate.c | 7 +--
> target/unicore32/translate.c | 4 +-
> tcg/tcg.c | 28 ++++++----
> tests/test-logging.c | 74 ++++++++++++++++++++++++++
> util/log.c | 99 ++++++++++++++++++++++++++++-------
> 18 files changed, 273 insertions(+), 69 deletions(-)
--
Alex Bennée
[PATCH 3/4] qemu_log_lock/unlock now preserves the qemu_logfile handle., Robert Foley, 2019/11/07
Re: [PATCH 0/4] Make the qemu_logfile handle thread safe., no-reply, 2019/11/07
Re: [PATCH 0/4] Make the qemu_logfile handle thread safe.,
Alex Bennée <=