[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak |
Date: |
Thu, 7 Nov 2019 21:31:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 07/11/2019 20:27, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/libqtest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 3706bccd8d..91e9cb220c 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -1274,6 +1274,7 @@ void qtest_qmp_device_add(QTestState *qts, const char
> *driver, const char *id,
> qdict_put_str(args, "id", id);
>
> qtest_qmp_device_add_qdict(qts, driver, args);
> + qobject_unref(args);
> }
>
> static void device_deleted_cb(void *opaque, const char *name, QDict *data)
>
Stupid question: where is the qobject_ref()?
Thanks,
Laurent
- [PATCH 0/3] Some memory leak fixes, Marc-André Lureau, 2019/11/07
- [PATCH 1/3] virtio-input: fix memory leak on unrealize, Marc-André Lureau, 2019/11/07
- [PATCH 2/3] qtest: fix qtest_qmp_device_add leak, Marc-André Lureau, 2019/11/07
- [PATCH 3/3] cpu-plug-test: fix leaks, Marc-André Lureau, 2019/11/07
- Re: [PATCH 0/3] Some memory leak fixes, no-reply, 2019/11/07
- Re: [PATCH 0/3] Some memory leak fixes, Michael S. Tsirkin, 2019/11/08