[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror
From: |
Peter Krempa |
Subject: |
Re: [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror |
Date: |
Fri, 8 Nov 2019 14:30:27 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Nov 08, 2019 at 13:16:54 +0300, Vladimir Sementsov-Ogievskiy wrote:
> To correspond to blockdev-mirror command and make it possible to
> deprecate implicit filters in the next commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> qapi/block-core.json | 7 +++++++
> blockdev.c | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index aa97ee2641..93530d3a13 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1992,6 +1992,12 @@
> # @on-target-error: the action to take on an error on the target,
> # default 'report' (no limitations, since this applies to
> # a different block device than @device).
> +#
> +# @filter-node-name: the node name that should be assigned to the
> +# filter driver that the mirror job inserts into the graph
> +# above @device. If this option is not given, a node name
> is
> +# autogenerated. (Since: 4.2)
> +#
Speaking for libvirt and based on what I've responded to patch 2 there's
no value in adding this parameter for libvirt's use.
This also kind of means that drive-mirror can be deprecated together
with deprecating -drive.