[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces
From: |
Klaus Jensen |
Subject: |
[PATCH v3 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces |
Date: |
Mon, 11 Nov 2019 13:25:24 +0100 |
Hi all,
This v3 fixes a number of issues found doing v2[1]. Below is a list of
commits that changed for v3.
* In "nvme: add missing fields in the identify controller data
structure", the size of the RTD3R field was incorrectly two instead of
four bytes wide.
* Fix status code for an invalid NSID for the SMART/Health log page in
"nvme: add support for the get log page command".
* The naming of reserved fields was changed in "nvme: bump supported
specification version to 1.3" to align with existing convention.
* "nvme: support multiple namespaces" got a bunch of fixes. The nvme_ns
function did not error out when the given nsid was above the number of
valid namespace ids. As reported by Ross, the device did not correctly
handle inactive namespaces. The controller should return a zeroed
identify page in response to the Identify Namespace command for an
inactive namespace.
Previously, each namespace would contain all of the "common block
parameters" such as "logical_block_size", "write-cache", etc. For the
NVMe controller, the write cache is controller wide, so fix handling
of this feature by removing all those parameters for the nvme-ns
device and only keep the "drive" parameter. Setting the write-cache
parameter on the nvme device will trickle down to the nvme-ns devices
instead. Thus, sending a Set Feature command for the Volatile Write
Cache feature will also enable/disable the write cache for all
namespaces (as it should according to the specification).
* Fix a bunch of -Werror=int-to-pointer-cast errors in the "nvme: handle
dma errors" patch.
After conversations with Michael S. Tsirkin, my patch for dma_memory_rw
("pci: pass along the return value of dma_memory_rw") is now included in
this series (with Reviewed-By by Philippe and Michael). The patch is
required for patch "nvme: handle dma errors" to actually do fix
anything.
[1]: https://patchwork.kernel.org/cover/11190045/
Klaus Jensen (21):
nvme: remove superfluous breaks
nvme: move device parameters to separate struct
nvme: add missing fields in the identify controller data structure
nvme: populate the mandatory subnqn and ver fields
nvme: allow completion queues in the cmb
nvme: add support for the abort command
nvme: refactor device realization
nvme: add support for the get log page command
nvme: add support for the asynchronous event request command
nvme: add logging to error information log page
nvme: add missing mandatory features
nvme: bump supported specification version to 1.3
nvme: refactor prp mapping
nvme: allow multiple aios per command
nvme: add support for scatter gather lists
nvme: support multiple namespaces
nvme: bump controller pci device id
nvme: remove redundant NvmeCmd pointer parameter
nvme: make lba data size configurable
pci: pass along the return value of dma_memory_rw
nvme: handle dma errors
block/nvme.c | 18 +-
hw/block/Makefile.objs | 2 +-
hw/block/nvme-ns.c | 158 ++++
hw/block/nvme-ns.h | 62 ++
hw/block/nvme.c | 1867 +++++++++++++++++++++++++++++++++-------
hw/block/nvme.h | 230 ++++-
hw/block/trace-events | 38 +-
include/block/nvme.h | 130 ++-
include/hw/pci/pci.h | 3 +-
9 files changed, 2126 insertions(+), 382 deletions(-)
create mode 100644 hw/block/nvme-ns.c
create mode 100644 hw/block/nvme-ns.h
--
2.24.0
- [PATCH v3 00/20] nvme: support NVMe v1.3d, SGLs and multiple namespaces,
Klaus Jensen <=
- [PATCH v3 06/21] nvme: add support for the abort command, Klaus Jensen, 2019/11/11
- [PATCH v3 01/21] nvme: remove superfluous breaks, Klaus Jensen, 2019/11/11
- [PATCH v3 03/21] nvme: add missing fields in the identify controller data structure, Klaus Jensen, 2019/11/11
- [PATCH v3 10/21] nvme: add logging to error information log page, Klaus Jensen, 2019/11/11
- [PATCH v3 05/21] nvme: allow completion queues in the cmb, Klaus Jensen, 2019/11/11
- [PATCH v3 04/21] nvme: populate the mandatory subnqn and ver fields, Klaus Jensen, 2019/11/11
- [PATCH v3 02/21] nvme: move device parameters to separate struct, Klaus Jensen, 2019/11/11
- [PATCH v3 08/21] nvme: add support for the get log page command, Klaus Jensen, 2019/11/11
- [PATCH v3 07/21] nvme: refactor device realization, Klaus Jensen, 2019/11/11
- [PATCH v3 09/21] nvme: add support for the asynchronous event request command, Klaus Jensen, 2019/11/11