[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type |
Date: |
Mon, 11 Nov 2019 16:49:57 -0500 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote:
> > @@ -310,7 +302,7 @@ class BootLinuxConsole(Test):
> > def test_arm_emcraft_sf2(self):
> > """
> > :avocado: tags=arch:arm
> > - :avocado: tags=machine:emcraft_sf2
> > + :avocado: tags=machine:emcraft-sf2
>
> Maybe add a comment about this change, "Since avocado 72(?) we can ... so
> use ..."
>
You mean on this specific test docstring? I'm confused if there's a
special reason for doing it here, of if you're suggesting adding a
similar command to all tag entries which make use of the extended
character set (which I think would be too verbose, repetitve, and hard
to maintain).
> > diff --git a/tests/acceptance/cpu_queries.py
> > b/tests/acceptance/cpu_queries.py
> > index af47d2795a..293dccb89a 100644
> > --- a/tests/acceptance/cpu_queries.py
> > +++ b/tests/acceptance/cpu_queries.py
> > @@ -20,8 +20,8 @@ class QueryCPUModelExpansion(Test):
> > def test(self):
> > """
> > :avocado: tags=arch:x86_64
> > + :avocado: tags=machine:none
>
> Not to confuse with None :)
>
Yep! :)
- Cleber.
[PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir, Cleber Rosa, 2019/11/04
[PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH, Cleber Rosa, 2019/11/04