[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message |
Date: |
Tue, 12 Nov 2019 08:52:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 12/11/2019 07:40, Joel Stanley wrote:
> Users benefit from knowing which watchdog timer has expired. The address
> of the watchdog's registers unambiguously indicates which has expired,
> so log that.
>
> Signed-off-by: Joel Stanley <address@hidden>
The format below should be using HWADDR_PRIx. No need to resend.
I will fix it.
Reviewed-by: Cédric Le Goater <address@hidden>
C.
> ---
> hw/watchdog/wdt_aspeed.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 145be6f99ce2..5697ed83325a 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev)
> return;
> }
>
> - qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n");
> + qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %08lx expired.\n",
> + s->iomem.addr);
> watchdog_perform_action();
> timer_del(s->timer);
> }
>
- [PATCH 0/4] arm/aspeed: Watchdog and SDRAM fixes, Joel Stanley, 2019/11/12
- [PATCH 1/4] aspeed/sdmc: Make ast2600 default 1G, Joel Stanley, 2019/11/12
- [PATCH 2/4] aspeed/scu: Fix W1C behavior, Joel Stanley, 2019/11/12
- [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message, Joel Stanley, 2019/11/12
- Re: [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message,
Cédric Le Goater <=
- [PATCH 4/4] watchdog/aspeed: Fix AST2600 frequency behaviour, Joel Stanley, 2019/11/12
- Re: [PATCH 0/4] arm/aspeed: Watchdog and SDRAM fixes, no-reply, 2019/11/12