[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transact
From: |
Sergio Lopez |
Subject: |
[PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transactions |
Date: |
Tue, 12 Nov 2019 12:30:08 +0100 |
Change qmp_drive_backup() to create and start a transaction instead of
calling do_drive_backup directly.
Signed-off-by: Sergio Lopez <address@hidden>
---
blockdev.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b32855f702..5e85fc042e 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3676,14 +3676,13 @@ static BlockJob *do_backup_common(BackupCommon *backup,
return job;
}
-void qmp_drive_backup(DriveBackup *arg, Error **errp)
+void qmp_drive_backup(DriveBackup *backup, Error **errp)
{
-
- BlockJob *job;
- job = do_drive_backup(arg, NULL, errp);
- if (job) {
- job_start(&job->job);
- }
+ TransactionAction action = {
+ .type = TRANSACTION_ACTION_KIND_DRIVE_BACKUP,
+ .u.drive_backup.data = backup,
+ };
+ blockdev_do_action(&action, errp);
}
BlockDeviceInfoList *qmp_query_named_block_nodes(Error **errp)
--
2.23.0
- [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup, Sergio Lopez, 2019/11/12
- [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup, Sergio Lopez, 2019/11/12
- [PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transactions,
Sergio Lopez <=
- [PATCH v3 2/8] blockdev: fix coding style issues in drive_backup_prepare, Sergio Lopez, 2019/11/12
- [PATCH v3 8/8] blockdev: honor bdrv_try_set_aio_context() context requirements, Sergio Lopez, 2019/11/12
- [PATCH v3 6/8] blockdev: place blockdev_backup_prepare with the other related transaction helpers, Sergio Lopez, 2019/11/12
- [PATCH v3 3/8] blockdev: place drive_backup_prepare with the other related transaction functions, Sergio Lopez, 2019/11/12
- [PATCH v3 7/8] blockdev: change qmp_blockdev_backup to make use of transactions, Sergio Lopez, 2019/11/12
- [PATCH v3 5/8] blockdev: merge blockdev_backup_prepare with do_blockdev_backup, Sergio Lopez, 2019/11/12
- Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup, no-reply, 2019/11/12