[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1 |
|
Date: |
Tue, 12 Nov 2019 18:05:33 +0100 |
> Am 12.11.2019 um 17:58 schrieb Cornelia Huck <address@hidden>:
>
> On Mon, 11 Nov 2019 10:28:08 -0500
> Janosch Frank <address@hidden> wrote:
>
>> We need to actually fetch the cpu mask and set it. As we invert the
>> short psw indication in the mask, SIE will report a specification
>> exception, if it wasn't present in the reset psw.
>>
>> Signed-off-by: Janosch Frank <address@hidden>
>> ---
>> target/s390x/cpu.c | 12 ++++++++++--
>> target/s390x/cpu.h | 1 +
>> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> So, is this change -rc material, or should it go in during the next
> release? I'm a bit confused here.
IMHO, this is not urgent and can wait.
>
> [Also, does this need a change in the tcg code, or is that something
> that should just be done eventually? Sorry, drowning a bit in mails
> here...]
We‘re missing many checks when loading/running a new PSW for TCG, not just this
scenario. So this should be done at one point but is not urgent at all.