qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for


From: Aleksandar Markovic
Subject: Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board
Date: Thu, 14 Nov 2019 12:33:57 +0000

Hi, Philippe,

> From: Philippe Mathieu-Daudé <address@hidden>
> 
> Hi Aleksandar,
> 
> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <address@hidden>
> >
> > Change the maintainership for Fulong 2E board to improve its quality.
> 
> IIRC you told me once this board is named Fuloong, and its CPU is a
‎> Loongson, both with 2x 'o' :) I have a patch renaming the various
> occurrences.
> 

I still think that the oficial name is "Fuloong 2E", however, it is
shortened to "Fulong 2E" quite often in communication, and, it seems,
sometimes even in various docs/app notes etc.

Can perhaps Huacai Chen enlighten us regarding the right spelling?

> > Signed-off-by: Aleksandar Markovic <address@hidden>
> > ---
> >   MAINTAINERS | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index fd9ba32..3bf2144 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -976,9 +976,10 @@ S: Maintained
> >   F: hw/mips/mips_r4k.c
> >
> >   Fulong 2E
> > -M: Aleksandar Markovic <address@hidden>
> > -R: Aleksandar Rikalo <address@hidden>
> > -S: Odd Fixes
> > +M: Philippe Mathieu-Daudé <address@hidden>
> 
> I am happy to keep the Fuloong working, but this will be on my personal
> (hobbyist) time. This area is not a priority for my employer, so I'll
> use my personal email: address@hidden.
> 

OK.

> The original author is active on the Linux kernel, let ask him if he'd
> be OK to keep an eye on his work.
> 
> Huacai, would you agree to be listed as a reviewer on the Fuloong
> related QEMU files? You don't have to worry about the generic QEMU code
> plate (like keeping API up to date) I'll manage that, but I'd like to
> have you listed to assert the hardware is properly modeled.
> 
> You would appear as:
> R: Huacai Chen <address@hidden>
> 

That is a great idea!

Please, Chen, get involved, you would be very welcomed, there is a place
for you in QEMU community!


> > +R: Hervé Poussineau <address@hidden>
> 
> I don't think Hervé is interested by this board, he has not modified the
> code.
> 
> > +R: Aleksandar Markovic <address@hidden>
> > +S: Maintained
> 
> Let keep it as "Odd Fixes" :)
> 

OK.

>    Odd Fixes:   It has a maintainer but they don't have
>                 time to do much other than throw the odd
>                 patch in.
> 
> >   F: hw/mips/mips_fulong2e.c
> >   F: hw/isa/vt82c686.c
> >   F: hw/pci-host/bonito.c
> >
> 
> So the patch would be:
> 
> -- 8< --
>   Fulong 2E
> -M: Aleksandar Markovic <address@hidden>
> -R: Aleksandar Rikalo <address@hidden>
> +M: Philippe Mathieu-Daudé <address@hidden>
> +R: Aleksandar Markovic <address@hidden>
> +R: Huacai Chen <address@hidden>
>   S: Odd Fixes
>   F: hw/mips/mips_fulong2e.c
>   F: hw/isa/vt82c686.c

Plus possible s/Fulong 2E/Fuloong 2E/

> ---
> 
> But let's wait to see what Huacai Chen thinks of it, before posting it.
> 
> Thanks for taking care of those changes!
> 
> Phil.
> 
> 

Thank you!

Aleksandar


reply via email to

[Prev in Thread] Current Thread [Next in Thread]