|
From: | Eric Blake |
Subject: | Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards |
Date: | Tue, 19 Nov 2019 08:14:01 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 11/18/19 5:58 PM, Taylor Simpson wrote:In addition to what others have said, you have an atypical and long subject line. You'll want to rewrite it to match more typical subject lines (around 65 characters) then a blank line then the additional details. 'git shortlog -30' might give you some ideas on how to do it; you'll probably want to use 'hexagon:' as your prefix.
Signed-off-by: Taylor Simpson <address@hidden> ---
31 files changed, 2184 insertions(+)
That's a big patch. How much of it is copied verbatim from elsewhere and how much is new code? Splitting the patch along those lines makes review of the non-copied portion easier.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |