[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1
From: |
Peter Maydell |
Subject: |
Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1 |
Date: |
Wed, 20 Nov 2019 10:45:53 +0000 |
On Wed, 20 Nov 2019 at 08:10, Laurent Vivier <address@hidden> wrote:
> For the moment we don't have a better solution, Josh Kunz tried to
> rework [1] patches from Miloš Stojanović [2] but it doesn't seem to be
> an easy task.
>
> So I agree we need a generic solution to fix this problem, but in the
> meantime I told to Taylor if he doesn't care about Go on hexagon he can
> do this change specifically to his target (perhaps we can have cleaner
> approach by containing this change into linux-user/hexagon). And what I
> understand is hexagon libc (musl) doesn't work without this.
I really don't like target-specific ifdeffery that changes behaviour
that shouldn't be target specific. They reduce the chances we ever
try to go back and actually fix the underlying problem correctly,
and they can be awkward to undo without breaking things.
As far as I can tell there is nothing special about Hexagon here.
thanks
-- PMM