[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 15/37] serial-mm: use sysbus facilities
From: |
Marc-André Lureau |
Subject: |
[PATCH v4 15/37] serial-mm: use sysbus facilities |
Date: |
Wed, 20 Nov 2019 19:24:20 +0400 |
Make SerialMM a regular sysbus device, by registering the irq, and the
mmio region. Reexport the internal serial properties.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/char/serial.c | 35 ++++++++++++++++++++++++-----------
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index 1c16fed4d1..e0f1a99e8b 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -1073,21 +1073,18 @@ SerialMM *serial_mm_init(MemoryRegion *address_space,
Chardev *chr, enum device_endian end)
{
SerialMM *smm = SERIAL_MM(qdev_create(NULL, TYPE_SERIAL_MM));
- SerialState *s = &smm->serial;
+ MemoryRegion *mr;
qdev_prop_set_uint8(DEVICE(smm), "regshift", regshift);
- s->irq = irq;
- qdev_prop_set_uint32(DEVICE(s), "baudbase", baudbase);
- qdev_prop_set_chr(DEVICE(s), "chardev", chr);
- qdev_set_legacy_instance_id(DEVICE(s), base, 2);
- qdev_prop_set_uint8(DEVICE(self), "endianness", end);
-
- qdev_init_nofail(DEVICE(s));
+ qdev_prop_set_uint32(DEVICE(smm), "baudbase", baudbase);
+ qdev_prop_set_chr(DEVICE(smm), "chardev", chr);
+ qdev_set_legacy_instance_id(DEVICE(smm), base, 2);
+ qdev_prop_set_uint8(DEVICE(smm), "endianness", end);
qdev_init_nofail(DEVICE(smm));
- memory_region_init_io(&s->io, NULL, &serial_mm_ops[end], smm,
- "serial", 8 << regshift);
- memory_region_add_subregion(address_space, base, &s->io);
+ sysbus_connect_irq(SYS_BUS_DEVICE(smm), 0, irq);
+ mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(smm), 0);
+ memory_region_add_subregion(address_space, base, mr);
return smm;
}
@@ -1098,6 +1095,8 @@ static void serial_mm_instance_init(Object *o)
object_initialize_child(o, "serial", &smm->serial, sizeof(smm->serial),
TYPE_SERIAL, &error_abort, NULL);
+
+ qdev_alias_all_properties(DEVICE(&smm->serial), o);
}
static Property serial_mm_properties[] = {
@@ -1111,11 +1110,25 @@ static Property serial_mm_properties[] = {
DEFINE_PROP_END_OF_LIST(),
};
+static void serial_mm_realize(DeviceState *dev, Error **errp)
+{
+ SerialMM *smm = SERIAL_MM(dev);
+ SerialState *s = &smm->serial;
+
+ qdev_init_nofail(DEVICE(s));
+
+ memory_region_init_io(&s->io, NULL, &serial_mm_ops[smm->endianness], smm,
+ "serial", 8 << smm->regshift);
+ sysbus_init_mmio(SYS_BUS_DEVICE(smm), &s->io);
+ sysbus_init_irq(SYS_BUS_DEVICE(smm), &smm->serial.irq);
+}
+
static void serial_mm_class_init(ObjectClass *klass, void* data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
dc->props = serial_mm_properties;
+ dc->realize = serial_mm_realize;
}
static const TypeInfo serial_mm_info = {
--
2.24.0
- [PATCH v4 11/37] serial: replace serial_exit_core() with unrealize, (continued)
- [PATCH v4 11/37] serial: replace serial_exit_core() with unrealize, Marc-André Lureau, 2019/11/20
- [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Marc-André Lureau, 2019/11/20
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Peter Maydell, 2019/11/21
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Marc-André Lureau, 2019/11/21
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Peter Maydell, 2019/11/21
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Marc-André Lureau, 2019/11/21
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Peter Maydell, 2019/11/22
- Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device, Marc-André Lureau, 2019/11/22
[PATCH v4 13/37] serial-mm: add "regshift" property, Marc-André Lureau, 2019/11/20
[PATCH v4 14/37] serial-mm: add endianness property, Marc-André Lureau, 2019/11/20
[PATCH v4 15/37] serial-mm: use sysbus facilities,
Marc-André Lureau <=
[PATCH v4 16/37] serial: make SerialIO a sysbus device, Marc-André Lureau, 2019/11/20
[PATCH v4 17/37] mips: inline serial_init(), Marc-André Lureau, 2019/11/20
Re: [PATCH v4 17/37] mips: inline serial_init(), Aleksandar Markovic, 2019/11/27
[PATCH v4 18/37] mips: baudbase is 115200 by default, Marc-André Lureau, 2019/11/20