[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 37/37] qdev/qom: remove some TODO limitations now that PROP_PT
From: |
Marc-André Lureau |
Subject: |
[PATCH v4 37/37] qdev/qom: remove some TODO limitations now that PROP_PTR is gone |
Date: |
Wed, 20 Nov 2019 19:24:42 +0400 |
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/core/qdev.c | 8 --------
qom/qom-qmp-cmds.c | 10 ----------
2 files changed, 18 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index c79befc865..c7b3f0dec5 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -736,14 +736,6 @@ void qdev_property_add_static(DeviceState *dev, Property
*prop,
if (prop->info->create) {
prop->info->create(obj, prop, &local_err);
} else {
- /*
- * TODO qdev_prop_ptr does not have getters or setters. It must
- * go now that it can be replaced with links. The test should be
- * removed along with it: all static properties are read/write.
- */
- if (!prop->info->get && !prop->info->set) {
- return;
- }
object_property_add(obj, prop->name, prop->info->name,
prop->info->get, prop->info->set,
prop->info->release,
diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 236e8e41dd..f4494f98ac 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -142,16 +142,6 @@ static ObjectPropertyInfo
*make_device_property_info(ObjectClass *klass,
continue;
}
- /*
- * TODO Properties without a parser are just for dirty hacks.
- * qdev_prop_ptr is the only such PropertyInfo. It's marked
- * for removal. This conditional should be removed along with
- * it.
- */
- if (!prop->info->set && !prop->info->create) {
- return NULL; /* no way to set it, don't show */
- }
-
info = g_malloc0(sizeof(*info));
info->name = g_strdup(prop->name);
info->type = default_type ? g_strdup(default_type)
--
2.24.0
- Re: [PATCH v4 28/37] qdev: use g_strcmp0() instead of open-coding it, (continued)
- [PATCH v4 29/37] RFC: mips/cps: fix setting saar property, Marc-André Lureau, 2019/11/20
- [PATCH v4 30/37] cris: improve passing PIC interrupt vector to the CPU, Marc-André Lureau, 2019/11/20
- [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR, Marc-André Lureau, 2019/11/20
- [PATCH v4 32/37] omap-intc: remove PROP_PTR, Marc-André Lureau, 2019/11/20
- [PATCH v4 33/37] omap-i2c: remove PROP_PTR, Marc-André Lureau, 2019/11/20
- [PATCH v4 34/37] omap-gpio: remove PROP_PTR, Marc-André Lureau, 2019/11/20
- [PATCH v4 35/37] qdev: remove PROP_MEMORY_REGION, Marc-André Lureau, 2019/11/20
- [PATCH v4 36/37] qdev: remove QDEV_PROP_PTR, Marc-André Lureau, 2019/11/20
- [PATCH v4 37/37] qdev/qom: remove some TODO limitations now that PROP_PTR is gone,
Marc-André Lureau <=