Re: [PATCH v4 28/37] qdev: use g_strcmp0() instead of open-coding it

[Philippe Mathieu-Daudé]

On 11/20/19 4:24 PM, Marc-André Lureau wrote:
> Minor code simplification.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>   hw/core/qdev.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index cf1ba28fe3..c79befc865 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -394,11 +394,8 @@ static NamedGPIOList *qdev_get_named_gpio_list(DeviceState 
> *dev,
>       NamedGPIOList *ngl;
>   
>       QLIST_FOREACH(ngl, &dev->gpios, node) {
> -        /* NULL is a valid and matchable name, otherwise do a normal
> -         * strcmp match.
> -         */
> -        if ((!ngl->name && !name) ||
> -                (name && ngl->name && strcmp(name, ngl->name) == 0)) {
> +        /* NULL is a valid and matchable name. */
> +        if (g_strcmp0(name, ngl->name) == 0) {

Cocci pattern?

>               return ngl;
>           }
>       }

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>