[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CP
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CPU models |
Date: |
Mon, 25 Nov 2019 11:21:10 -0300 |
On Thu, Nov 21, 2019 at 03:12:45PM +0100, Kashyap Chamarthy wrote:
> On Wed, Nov 20, 2019 at 01:49:12PM -0300, Eduardo Habkost wrote:
> > We have been trying to avoid adding new aliases for CPU model
> > versions, but in the case of changes in defaults introduced by
> > the TAA mitigation patches, the aliases might help avoid user
> > confusion when applying host software updates.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Tested-by: Kashyap Chamarthy <address@hidden>
>
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg03501.html
Thanks!
>
> - - -
>
> Should we (can do it, if you already don't have a patch WIP for it)
> also update this file to reflect this?
> https://git.qemu.org/?p=qemu.git;a=blob;f=docs/qemu-cpu-models.texi
Yes, we should. Thanks for the reminder!
>
> While at it ... I wonder if it's worth making a separte doc
> (versioned-cpu-models.rst) explaining the versioned CPU models, usage,
> etc.
>
> There was a very useful discussion between you and Dan Berrangé on this
> list (Message-Id: <address@hidden>, the
> first version of the thread: "[PATCH 4/6] i386: Infrastructure for
> versioned CPU models"). Could potentially incorporate some of that
> content.
>
We should, but I don't think I can do it in time for QEMU 4.2.
> > ---
> > target/i386/cpu.c | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> [...]
>
> --
> /kashyap
--
Eduardo