[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate(
From: |
Alberto Garcia |
Subject: |
Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate() |
Date: |
Mon, 25 Nov 2019 16:06:36 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 22 Nov 2019 05:05:05 PM CET, Kevin Wolf wrote:
> @@ -3405,6 +3412,7 @@ typedef struct TruncateCo {
> int64_t offset;
> bool exact;
> PreallocMode prealloc;
> + bool no_fallback;
> Error **errp;
> int ret;
> } TruncateCo;
You add the 'no_fallback' field here...
> int bdrv_truncate(BdrvChild *child, int64_t offset, bool exact,
> - PreallocMode prealloc, Error **errp)
> + PreallocMode prealloc, bool no_fallback, Error **errp)
> {
> Coroutine *co;
> TruncateCo tco = {
...but then you don't use it when the structure is initialized.
Berto
- [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays, Kevin Wolf, 2019/11/22
- [PATCH v3 1/8] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter, Kevin Wolf, 2019/11/22
- [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported, Kevin Wolf, 2019/11/22
- [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate(), Kevin Wolf, 2019/11/22
- [PATCH v3 4/8] block: truncate: Don't make backing file data visible, Kevin Wolf, 2019/11/22
- [PATCH v3 5/8] iotests: Add qemu_io_log(), Kevin Wolf, 2019/11/22
- [PATCH v3 7/8] iotests: Support job-complete in run_job(), Kevin Wolf, 2019/11/22
- [PATCH v3 6/8] iotests: Fix timeout in run_job(), Kevin Wolf, 2019/11/22
- [PATCH v3 8/8] iotests: Test committing to short backing file, Kevin Wolf, 2019/11/22