Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic

[Thomas Huth]

On 24/11/2019 16.17, Aleksandar Markovic wrote:
> 
> 
> On Sunday, November 24, 2019, Michael Rolnik <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     This includes:
>     - CPU data structures
>     - object model classes and functions
>     - migration functions
>     - GDB hooks
> 
>     Co-developed-by: Michael Rolnik <address@hidden
>     <mailto:address@hidden>>
>     Co-developed-by: Sarah Harris <address@hidden
>     <mailto:address@hidden>>
>     Signed-off-by: Michael Rolnik <address@hidden
>     <mailto:address@hidden>>
>     Signed-off-by: Sarah Harris <address@hidden
>     <mailto:address@hidden>>
>     Signed-off-by: Michael Rolnik <address@hidden
>     <mailto:address@hidden>>
>     Acked-by: Igor Mammedov <address@hidden
>     <mailto:address@hidden>>
>     ---
>      target/avr/cpu-param.h |  37 +++
>      target/avr/cpu-qom.h   |  54 ++++
>      target/avr/cpu.h       | 253 ++++++++++++++++++
>      target/avr/cpu.c       | 576 +++++++++++++++++++++++++++++++++++++++++
>      target/avr/gdbstub.c   |  85 ++++++
>      target/avr/machine.c   | 121 +++++++++
>      gdb-xml/avr-cpu.xml    |  49 ++++
>      7 files changed, 1175 insertions(+)
>      create mode 100644 target/avr/cpu-param.h
>      create mode 100644 target/avr/cpu-qom.h
>      create mode 100644 target/avr/cpu.h
>      create mode 100644 target/avr/cpu.c
>      create mode 100644 target/avr/gdbstub.c
>      create mode 100644 target/avr/machine.c
>      create mode 100644 gdb-xml/avr-cpu.xml
> 
>     diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h
>     new file mode 100644
>     index 0000000000..ccd1ea3429
>     --- /dev/null
>     +++ b/target/avr/cpu-param.h
>     @@ -0,0 +1,37 @@
>     +/*
>     + * QEMU AVR CPU
>     + *
>     + * Copyright (c) 2019 Michael Rolnik
>     + *
>     + * This library is free software; you can redistribute it and/or
>     + * modify it under the terms of the GNU Lesser General Public
>     + * License as published by the Free Software Foundation; either
>     + * version 2.1 of the License, or (at your option) any later version.
>     + *
> 
> 
> I think version 2 would be more fitting to QEMU ovarall license than 2.1
> (see LICENCE file in QEMU root dir).
> 
> Peter, am I right or wrong regarding GPL 2 vs. 2.1 (My interpretation is
> that 2 is the best "default" for new files)? The wording in "LICENSE" is
> frankly not entirely clear, and I see many new files using 2.1.

 Hi Aleksandar,

I think you mix up GPL and LGPL here. This file is licensed under the
LGPL, so version 2.1 is perfectly fine here (see COPYING.LIB in the root
directory). For the GPL, there was never a 2.1, so if it would be GPL,
version 2 would be appropriate. Bit since it's LGPL, 2.1 is better indeed.

 Thomas