[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/8] pseries: fix migration-test and pxe-test
From: |
David Gibson |
Subject: |
[PULL 1/8] pseries: fix migration-test and pxe-test |
Date: |
Tue, 26 Nov 2019 17:01:44 +1100 |
From: Laurent Vivier <address@hidden>
Commit 29cb4187497d ("spapr: Set VSMT to smp_threads by default")
has introduced a new default value for VSMT that is not supported
by old kernels (before 4.13 kernel) and this breaks "make check"
on these kernels.
To fix that, explicitly set in the involved tests the value that was
used as the default value before the change.
Cc: Greg Kurz <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Acked-by: Thomas Huth <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
tests/migration-test.c | 4 ++--
tests/pxe-test.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index ac780dffda..ebd77a581a 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -614,7 +614,7 @@ static int test_migrate_start(QTestState **from, QTestState
**to,
end_address = S390_TEST_MEM_END;
} else if (strcmp(arch, "ppc64") == 0) {
extra_opts = use_shmem ? get_shmem_opts("256M", shmem_path) : NULL;
- cmd_src = g_strdup_printf("-machine accel=%s -m 256M -nodefaults"
+ cmd_src = g_strdup_printf("-machine accel=%s,vsmt=8 -m 256M
-nodefaults"
" -name source,debug-threads=on"
" -serial file:%s/src_serial"
" -prom-env 'use-nvramrc?=true' -prom-env "
@@ -623,7 +623,7 @@ static int test_migrate_start(QTestState **from, QTestState
**to,
"until' %s %s", accel, tmpfs, end_address,
start_address, extra_opts ? extra_opts : "",
opts_src);
- cmd_dst = g_strdup_printf("-machine accel=%s -m 256M"
+ cmd_dst = g_strdup_printf("-machine accel=%s,vsmt=8 -m 256M"
" -name target,debug-threads=on"
" -serial file:%s/dest_serial"
" -incoming %s %s %s",
diff --git a/tests/pxe-test.c b/tests/pxe-test.c
index 948b0fbdc7..aaae54f755 100644
--- a/tests/pxe-test.c
+++ b/tests/pxe-test.c
@@ -46,15 +46,15 @@ static testdef_t x86_tests_slow[] = {
static testdef_t ppc64_tests[] = {
{ "pseries", "spapr-vlan",
- "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken" },
+ "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,vsmt=8" },
{ "pseries", "virtio-net-pci",
- "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken" },
+ "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,vsmt=8" },
{ NULL },
};
static testdef_t ppc64_tests_slow[] = {
{ "pseries", "e1000",
- "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken" },
+ "-machine cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,vsmt=8" },
{ NULL },
};
--
2.23.0
- [PULL 0/8] ppc-for-4.2 queue 20191126, David Gibson, 2019/11/26
- [PULL 8/8] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue, David Gibson, 2019/11/26
- [PULL 7/8] mos6522: update counters when timer interrupts are off, David Gibson, 2019/11/26
- [PULL 1/8] pseries: fix migration-test and pxe-test,
David Gibson <=
- [PULL 4/8] vfio/pci: Respond to KVM irqchip change notifier, David Gibson, 2019/11/26
- [PULL 5/8] spapr: Handle irq backend changes with VFIO PCI devices, David Gibson, 2019/11/26
- [PULL 6/8] spapr: Work around spurious warnings from vfio INTx initialization, David Gibson, 2019/11/26
- [PULL 3/8] vfio/pci: Split vfio_intx_update(), David Gibson, 2019/11/26
- [PULL 2/8] kvm: Introduce KVM irqchip change notifier, David Gibson, 2019/11/26
- Re: [PULL 0/8] ppc-for-4.2 queue 20191126, Peter Maydell, 2019/11/26