|
From: | Eric Blake |
Subject: | Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler |
Date: | Wed, 27 Nov 2019 13:49:58 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
[adding Markus] On 11/27/19 1:08 PM, Vladimir Sementsov-Ogievskiy wrote:
Make nbd_iter_channel_error errp handler well formed: rename local_err to errp_in, as it is IN-parameter here (which is unusual for Error**). Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> Reviewed-by: Eric Blake <address@hidden> --- v6: fix commit message add Eric's r-b
I'm surprised that you aren't including Markus on a lot of these patches - even though you've posted a lot of them as separate threads to make them easier for individual maintainers to pick up, it would also be possible for Markus to pick up a bunch of them at once through his error tree.
At any rate, I'll queue this one through my NBD tree for 5.0 if it does not make it through Markus' error tree or the trivial tree sooner.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |