Re: RE: [PATCH] Updating the GEM MAC IP to properly filter out the multicast addresses

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: RE: [PATCH] Updating the GEM MAC IP to properly filter out the 
multicast addresses
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
da627f2 Updating the GEM MAC IP to properly filter out the multicast addresses

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#36: FILE: hw/net/cadence_gem.c:319:
+/* IEEE has specified that the most significant bit of the most significant 
byte be used for

WARNING: Block comments use a leading /* on a separate line
#36: FILE: hw/net/cadence_gem.c:319:
+/* IEEE has specified that the most significant bit of the most significant 
byte be used for

WARNING: Block comments use a trailing */ on a separate line
#38: FILE: hw/net/cadence_gem.c:321:
+ * If its a 1, that means multicast, 0 means unicast.   */

total: 1 errors, 2 warnings, 54 lines checked

Commit da627f2a2cb5 (Updating the GEM MAC IP to properly filter out the 
multicast addresses) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden