[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/21] s390x: Fix latent query-cpu-definitions error handling bug
From: |
Markus Armbruster |
Subject: |
[PATCH 18/21] s390x: Fix latent query-cpu-definitions error handling bug |
Date: |
Sat, 30 Nov 2019 20:42:37 +0100 |
qmp_query_cpu_definitions() tries to ignore get_max_cpu_model()'s
errors. However, it crashes when its @errp argument is null or
&error_abort, and exit(1)s when it's &error_fatal. Messed up in
commit 38cba1f4d8 "s390x: return unavailable features via
query-cpu-definitions".
The bug can't bite as no caller actually passes such @errp values.
Fix it anyway.
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
target/s390x/cpu_models.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 3ed301b5e5..547bab8ac3 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -462,11 +462,7 @@ CpuDefinitionInfoList *qmp_query_cpu_definitions(Error
**errp)
.list = NULL,
};
- list_data.model = get_max_cpu_model(errp);
- if (*errp) {
- error_free(*errp);
- *errp = NULL;
- }
+ list_data.model = get_max_cpu_model(NULL);
object_class_foreach(create_cpu_model_list, TYPE_S390_CPU, false,
&list_data);
--
2.21.0
- Re: [PATCH 19/21] error: Clean up unusual names of Error * variables, (continued)
- [PATCH 08/21] exec: Fix latent file_ram_alloc() error handling bug, Markus Armbruster, 2019/11/30
- [PATCH 06/21] io: Fix Error usage in a comment <example>, Markus Armbruster, 2019/11/30
- [PATCH 16/21] s390/cpu_modules: Fix latent realize() error handling bugs, Markus Armbruster, 2019/11/30
- [PATCH 14/21] s390x/event-facility: Fix latent realize() error handling bug, Markus Armbruster, 2019/11/30
- [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug, Markus Armbruster, 2019/11/30
- [PATCH 07/21] tests: Clean up initialization of Error *err variables, Markus Armbruster, 2019/11/30
- [PATCH 15/21] s390x/cpu_models: Fix latent feature property error handling bugs, Markus Armbruster, 2019/11/30
- [PATCH 13/21] memory-device: Fix latent memory pre-plug error handling bugs, Markus Armbruster, 2019/11/30
- [PATCH 12/21] qga: Fix latent guest-get-fsinfo error handling bug, Markus Armbruster, 2019/11/30
- [PATCH 18/21] s390x: Fix latent query-cpu-definitions error handling bug,
Markus Armbruster <=
- [PATCH 11/21] hw/ipmi: Fix latent realize() error handling bugs, Markus Armbruster, 2019/11/30
- [PATCH 09/21] hw/acpi: Fix latent legacy CPU plug error handling bug, Markus Armbruster, 2019/11/30
- [PATCH 21/21] tests-blockjob: Use error_free_or_abort(), Markus Armbruster, 2019/11/30
- [PATCH 20/21] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize(), Markus Armbruster, 2019/11/30
- [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs, Markus Armbruster, 2019/11/30