qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv3] exynos4210_gic: Suppress gcc9 format-truncation warnings


From: Richard Henderson
Subject: Re: [PATCHv3] exynos4210_gic: Suppress gcc9 format-truncation warnings
Date: Mon, 2 Dec 2019 08:08:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1

On 12/1/19 6:08 AM, David Gibson wrote:
>  
> -    for (i = 0; i < s->num_cpu; i++) {
> +    /*
> +     * This clues in gcc that our on-stack buffers do, in fact have
> +     * enough room for the cpu numbers.  gcc 9.2.1 on 32-bit x86
> +     * doesn't figure this out, otherwise and gives spurious warnings.
> +     */
> +    assert(n <= EXYNOS4210_NCPUS);
> +    for (i = 0; i < n; i++) {
> +
>          /* Map CPU interface per SMP Core */

Watch out for the extra line added at the start of the block.  Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]