Re: [PATCH 0/2] Remove 'remote wakeup' flag from USB config descriptor

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/2] Remove 'remote wakeup' flag from USB config descriptor
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
91bc743 usb-redir: remove 'remote wakeup' flag from configuration descriptor
e3a79d7 usb-host: remove 'remote wakeup' flag from configuration descriptor

=== OUTPUT BEGIN ===
1/2 Checking commit e3a79d76824a (usb-host: remove 'remote wakeup' flag from 
configuration descriptor)
WARNING: Block comments use a leading /* on a separate line
#57: FILE: hw/usb/host-libusb.c:400:
+        /* If this is GET_DESCRIPTOR request for configuration descriptor,

WARNING: Block comments use a trailing */ on a separate line
#59: FILE: hw/usb/host-libusb.c:402:
+         * in Windows guest */

ERROR: line over 90 characters
#64: FILE: hw/usb/host-libusb.c:407:
+            xfer->actual_length > offsetof(struct libusb_config_descriptor, 
bmAttributes) &&

WARNING: line over 80 characters
#68: FILE: hw/usb/host-libusb.c:411:
+                trace_usb_host_remote_wakeup_removed(desc.idVendor, 
desc.idProduct);

WARNING: line over 80 characters
#78: FILE: hw/usb/host-libusb.c:1616:
+    DEFINE_PROP_BOOL("suppress-remote-wake", USBHostDevice, 
suppress_remote_wake, true),

total: 1 errors, 4 warnings, 53 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 91bc743fae4b (usb-redir: remove 'remote wakeup' flag from 
configuration descriptor)
WARNING: line over 80 characters
#72: FILE: hw/usb/redirect.c:2551:
+    DEFINE_PROP_BOOL("suppress-remote-wake", USBRedirDevice, 
suppress_remote_wake, true),

total: 0 errors, 1 warnings, 44 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden