Re: [PATCH v1 4/5] linux-user: log page table changes under -d page

[Richard Henderson]

On 12/1/19 1:26 AM, Richard Henderson wrote:
> On 11/28/19 7:46 PM, Alex Bennée wrote:
>> +    if (qemu_loglevel_mask(CPU_LOG_PAGE)) {
>> +        qemu_log_lock();
>> +        qemu_log("new page @ 0x"TARGET_ABI_FMT_lx" updates page map:\n", 
>> start);
>> +        log_page_dump();
>> +        qemu_log_unlock();
>> +    }
> 
> Hmm.  The language used here asserts a change, when we don't actually know 
> that
> for a fact.  It *probably* adds a new page, but it could be overwriting an old
> page.  Can you find a better wording here?

Also, if you're going to do this, you might as well instrument munmap and
mremap as well.  Otherwise we're missing transitions.


r~