[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling b
From: |
David Hildenbrand |
Subject: |
Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs |
Date: |
Tue, 3 Dec 2019 10:51:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
>> s390x: Fix query-cpu-model-FOO error API violations
>>
>> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(),
>> qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It
>> dereferences @errp when the visitor or the QOM setter fails. That's
>> wrong; see the big comment in error.h. Introduced in commit
>> 137974cea3 's390x/cpumodel: implement QMP interface
>> "query-cpu-model-expansion"'.
>>
>> Its three callers have the same issue. Introduced in commit
>> 4e82ef0502 's390x/cpumodel: implement QMP interface
>> "query-cpu-model-comparison"' and commit f1a47d08ef 's390x/cpumodel:
>> implement QMP interface "query-cpu-model-baseline"'.
>>
>> No caller actually passes null. To fix, splice in a local Error *err,
>> and error_propagate().
>>
>> Cc: David Hildenbrand <address@hidden>
>> Cc: Cornelia Huck <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> That sounds good to me.
Yes, something I would have enjoyed reading from the first sentence.
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb