Re: [PATCH v5 11/13] hw/s390x/ipl: replace deprecated qdev_reset_all registration

[Cornelia Huck]

On Fri, 18 Oct 2019 17:06:28 +0200
Damien Hedde <address@hidden> wrote:

> Replace deprecated qdev_reset_all by resettable_cold_reset_fn for
> the ipl registration in the main reset handlers.
> 
> This does not impact the behavior for the following reasons:
> + at this point resettable just call the old reset methods of devices
>   and buses in the same order than qdev/qbus.
> + resettable handlers registered with qemu_register_reset are
>   serialized; there is no interleaving.
> + eventual explicit calls to legacy reset API (device_reset or
>   qdev/qbus_reset) inside this reset handler will not be masked out
>   by resettable mechanism; they do not go through resettable api.
> 
> Signed-off-by: Damien Hedde <address@hidden>
> ---
> Cc: Cornelia Huck <address@hidden>
> Cc: address@hidden
> Cc: Christian Borntraeger <address@hidden>
> Cc: Thomas Huth <address@hidden>
> ---
>  hw/s390x/ipl.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <address@hidden>