[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/18] crypto: Fix certificate file error handling crash b
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 01/18] crypto: Fix certificate file error handling crash bug |
Date: |
Wed, 4 Dec 2019 09:45:02 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Dec 04, 2019 at 10:36:08AM +0100, Markus Armbruster wrote:
> qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by
> reference to g_file_get_contents(). When g_file_get_contents() fails,
> it'll try to set a GError. Unless @gerr is null by dumb luck, this
> logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr
> unchanged. qcrypto_tls_creds_load_cert() then dereferences the
> uninitialized @gerr.
>
> Fix by initializing @gerr properly.
>
> Fixes: 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03
> Cc: "Daniel P. Berrangé" <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> crypto/tlscredsx509.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 04/18] tests: Clean up initialization of Error *err variables, (continued)
- [PATCH v2 04/18] tests: Clean up initialization of Error *err variables, Markus Armbruster, 2019/12/04
- [PATCH v2 11/18] s390x/event-facility: Fix realize() error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 13/18] s390x/cpumodel: Fix realize() error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 08/18] hw/ipmi: Fix realize() error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 05/18] exec: Fix file_ram_alloc() error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 17/18] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize(), Markus Armbruster, 2019/12/04
- [PATCH v2 01/18] crypto: Fix certificate file error handling crash bug, Markus Armbruster, 2019/12/04
- Re: [PATCH v2 01/18] crypto: Fix certificate file error handling crash bug,
Daniel P . Berrangé <=
- [PATCH v2 07/18] hw/core: Fix fit_load_fdt() error handling violations, Markus Armbruster, 2019/12/04
- [PATCH v2 03/18] io: Fix Error usage in a comment <example>, Markus Armbruster, 2019/12/04
- [PATCH v2 18/18] tests-blockjob: Use error_free_or_abort(), Markus Armbruster, 2019/12/04
- [PATCH v2 14/18] s390x/cpumodel: Fix query-cpu-model-FOO error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 06/18] hw/acpi: Fix legacy CPU plug error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 10/18] memory-device: Fix memory pre-plug error API violations, Markus Armbruster, 2019/12/04
- [PATCH v2 16/18] error: Clean up unusual names of Error * variables, Markus Armbruster, 2019/12/04