Re: [PATCH v2 4/6] linux-user: log page table changes under -d page

[Richard Henderson]

On 12/5/19 4:25 AM, Alex Bennée wrote:
> The CPU_LOG_PAGE flag is woefully underused and could stand to do
> extra duty tracking page changes. If the user doesn't want to see the
> details as things change they still have the tracepoints available.
> 
> We push the locking into log_page_dump and pass a reason for the
> banner text.
> 
> Signed-off-by: Alex Bennée <address@hidden>
> 
> ---
>   v2
>     - reworded banner text
>     - moved locking into helper
>     - converted stray calls of page_dump
> ---
>  include/exec/log.h | 5 ++++-
>  bsd-user/main.c    | 2 +-
>  linux-user/main.c  | 2 +-
>  linux-user/mmap.c  | 8 ++++----
>  4 files changed, 10 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~