Re: [PATCH v2 3/5] target/arm: Handle trapping to EL2 of AArch32 VMRS instructions

[Marc Zyngier]

On 2019-12-06 14:08, Peter Maydell wrote:
> On Sun, 1 Dec 2019 at 12:20, Marc Zyngier <address@hidden> wrote:
> > HCR_EL2.TID3 requires that AArch32 reads of MVFR[012] are trapped to
> > EL2, and HCR_EL2.TID0 does the same for reads of FPSID.
> > In order to handle this, introduce a new TCG helper function that
> > checks for these control bits before executing the VMRC instruction.
> >
> > Tested with a hacked-up version of KVM/arm64 that sets the control
> > bits for 32bit guests.
> >
> > Reviewed-by: Edgar E. Iglesias <address@hidden>
> > Signed-off-by: Marc Zyngier <address@hidden>
> > ---
> >  target/arm/helper-a64.h        |  2 ++
> >  target/arm/translate-vfp.inc.c | 18 +++++++++++++++---
> >  target/arm/vfp_helper.c        | 29 +++++++++++++++++++++++++++++
> >  3 files changed, 46 insertions(+), 3 deletions(-)
> >
> > diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h
> > index a915c1247f..0af44dc814 100644
> > --- a/target/arm/helper-a64.h
> > +++ b/target/arm/helper-a64.h
> > @@ -102,3 +102,5 @@ DEF_HELPER_FLAGS_3(autda, TCG_CALL_NO_WG, i64, 
> > env, i64, i64)
> >  DEF_HELPER_FLAGS_3(autdb, TCG_CALL_NO_WG, i64, env, i64, i64)
> >  DEF_HELPER_FLAGS_2(xpaci, TCG_CALL_NO_RWG_SE, i64, env, i64)
> >  DEF_HELPER_FLAGS_2(xpacd, TCG_CALL_NO_RWG_SE, i64, env, i64)
> > +
> > +DEF_HELPER_3(check_hcr_el2_trap, void, env, i32, i32)
>
> This has to be in helper.h, not helper-a64.h, otherwise
> the arm-softmmu target won't build. helper-a64.h is for
> helper functions which only exist in the aarch64 binary.

Ah, fair enough. I guess I should build all targets rather than
limit myself to aarch64...

I'll fix that and repost the series, having hopefully addressed
Richard's comments.

Thanks,

        M.
--
Jazz is not dead. It just smells funny...