[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu-img: fix info --backing-chain --image-opts
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH] qemu-img: fix info --backing-chain --image-opts |
|
Date: |
Fri, 06 Dec 2019 11:42:35 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 05 Dec 2019 02:46:46 PM CET, Stefan Hajnoczi wrote:
> Only apply --image-opts to the topmost image when listing an entire
> backing chain. It is incorrect to treat backing filenames as image
> options. Assuming we have the backing chain t.IMGFMT.base <-
> t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows:
>
> $ qemu-img info --backing-chain --image-opts \
> driver=qcow2,file.driver=file,file.filename=t.IMGFMT
> qemu-img: Could not open 'TEST_DIR/t.IMGFMT.mid': Cannot find
> device=TEST_DIR/t.IMGFMT.mid nor node_name=TEST_DIR/t.IMGFMT.mid
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto